Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the fixed image height and hover cursor effect #1195 #1195

Closed
wants to merge 1 commit into from

Conversation

Aanchalll18
Copy link

@Aanchalll18 Aanchalll18 commented Nov 10, 2024

Issues Identification

Closes: #1194

Description

Summary

Set a fixed height for images and added a hover cursor effect to enhance user interaction.

Details

Set a uniform height for all images in the component to ensure consistency across different screen sizes and layouts.

Added a cursor change to the pointer on hover to indicate that images are interactive, improving the user experience.

Types of Changes

Please check the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Please check the boxes that apply

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [x ] My changes do not break the current system and pass all existing test cases
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes

Screenshots

Screen.Recording.2024-11-10.141909.mp4

Additional Information

No Additional informations.

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for pathsphere ready!

Name Link
🔨 Latest commit b8dbd5e
🔍 Latest deploy log https://app.netlify.com/sites/pathsphere/deploys/67307804eb302a00082344ab
😎 Deploy Preview https://deploy-preview-1195--pathsphere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aanchalll18 Aanchalll18 changed the title Set the fixed image height and hover cursor effect Set the fixed image height and hover cursor effect #1195 Nov 10, 2024
@Apoorva57
Copy link
Collaborator

@Aachallll issue number??

@Apoorva57
Copy link
Collaborator

@Aachallll you did not create the issue and directly raised a PR, this is why we are closing this PR. Kindly create an issue first.

@Apoorva57 Apoorva57 closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants